test(dogfood): match condensed CLAUDE.md format in scholar-config check#459
Merged
Merged
Conversation
Check [34] grepped for the literal two-word strings `teach solution`, `teach sync`, `teach validate-r`, but a03916b ("docs(claude): optimize — move teach/dispatcher detail to pointers") condensed CLAUDE.md's teach docs into a single subcommand list (`..., solution, sync, validate-r, ...`). The subcommands are still documented, so the doc is correct and the assertion was stale — failing 1/41 on dev independent of any feature work. Accept either form via an alternation: `teach <sub>` OR `[(,] ?<sub>[,)]`. The [(,]/[,)] boundaries keep it non-vacuous and stop it matching the `--sync` deploy flag on the same line (verified: removing the `sync` subcommand while keeping `--sync` still fails the check). Fixes the test, not the doc — re-adding per-command lines would undo the deliberate CLAUDE.md optimization. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the long-standing 1/41 failure in
dogfood-scholar-config-sync(present ondev, unrelated to any feature work).Root cause
Check [34] grepped for the literal strings
teach solution,teach sync,teach validate-r, but commita03916ba("docs(claude): optimize — move teach/dispatcher detail to pointers") condensed CLAUDE.md's teach docs into a single subcommand list (..., solution, sync, validate-r, ...). The subcommands are still documented — the assertion went stale.Fix
Accept either form via alternation:
teach <sub>OR[(,] ?<sub>[,)]. The character-class boundaries keep it non-vacuous and stop it matching the--syncdeploy flag on the same line.Fixes the test, not the doc — re-adding per-command lines would undo the deliberate CLAUDE.md optimization.
Verification
solutionfrom the list fails the check; removing thesyncsubcommand while keeping--syncalso fails (no false match).🤖 Generated with Claude Code